Skip to content

[OpenMP] [NFC] Remove KMP_NESTED_HOT_TEAMS macro #143584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2025
Merged

[OpenMP] [NFC] Remove KMP_NESTED_HOT_TEAMS macro #143584

merged 1 commit into from
Jul 21, 2025

Conversation

jpeyton52
Copy link
Contributor

The feature was introduced back in 2014 and has been on ever since. Leave the feature in place. Removing only the macro.

@llvmbot llvmbot added the openmp:libomp OpenMP host runtime label Jun 10, 2025
@jpeyton52
[OpenMP] [NFC] Remove KMP_NESTED_HOT_TEAMS macro
5264598 
The feature was introduced back in 2014 and has been on ever since.
@jpeyton52 jpeyton52 force-pushed the remove-macro-nested-hot-teams branch from 158f5d0 to 5264598 Compare June 10, 2025 19:07
TerryLWilmarth
TerryLWilmarth approved these changes Jul 18, 2025
View reviewed changes
Copy link
Contributor

@TerryLWilmarth TerryLWilmarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TerryLWilmarth TerryLWilmarth merged commit de011e3 into llvm:main Jul 21, 2025
7 checks passed
@llvm-ci
Copy link
Collaborator

llvm-ci commented Jul 21, 2025

LLVM Buildbot has detected a new failure on builder openmp-s390x-linux running on systemz-1 while building openmp at step 6 "test-openmp".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/88/builds/14178

Here is the relevant piece of the build log for the reference 
Step 6 (test-openmp) failure: 1200 seconds without output running [b'ninja', b'-j 4', b'check-openmp'], attempting to kill
...
PASS: ompd-test :: openmp_examples/example_3.c (445 of 455)
PASS: ompd-test :: openmp_examples/example_4.c (446 of 455)
PASS: ompd-test :: openmp_examples/example_5.c (447 of 455)
PASS: ompd-test :: openmp_examples/example_task.c (448 of 455)
UNSUPPORTED: ompd-test :: openmp_examples/ompd_bt.c (449 of 455)
PASS: ompd-test :: openmp_examples/fibonacci.c (450 of 455)
UNSUPPORTED: ompd-test :: openmp_examples/ompd_parallel.c (451 of 455)
PASS: ompd-test :: openmp_examples/parallel.c (452 of 455)
PASS: ompd-test :: openmp_examples/nested.c (453 of 455)
PASS: ompd-test :: openmp_examples/ompd_icvs.c (454 of 455)
command timed out: 1200 seconds without output running [b'ninja', b'-j 4', b'check-openmp'], attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=1321.126858

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TerryLWilmarth TerryLWilmarth TerryLWilmarth approved these changes

@hansangbae hansangbae Awaiting requested review from hansangbae

Assignees
No one assigned
Labels
openmp:libomp OpenMP host runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpeyton52 @llvm-ci @TerryLWilmarth @llvmbot